| Violation | Line |
|---|---|
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.gui.imagetable.ImageModel' | 10 |
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.gui.imagetable.ImagePane' | 11 |
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.gui.imagetable.ImageTable' | 12 |
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.gui.imagetable.ImageTableModel' | 13 |
| Avoid unused imports such as 'java.io.FileInputStream' | 21 |
| Avoid unused imports such as 'java.io.FileNotFoundException' | 22 |
| Avoid unused imports such as 'java.io.IOException' | 23 |
| Avoid unused imports such as 'java.io.InputStream' | 24 |
| Avoid unused imports such as 'java.util.List' | 25 |
| Avoid unused imports such as 'java.util.Vector' | 26 |
| JUnit tests should include assert() or fail() | 52 |
| Parameter 'aPanel' is not assigned and could be declared final | 52 |
| Local variable could be declared final | 53 |
| Avoid variables with short names like e | 55 |
| Avoid unused formal parameters such as 'args' | 69 |
| Parameter 'args' is not assigned and could be declared final | 69 |
| Avoid unused local variables such as 'modPackage' | 70 |
| Local variable could be declared final | 70 |
| Local variable could be declared final | 78 |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 116 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like cachedNameMaxWidth | 14 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 13 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 14 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 14 |
| Parameter 'other' is not assigned and could be declared final | 57 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 19 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 21 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Avoid excessively long variable names like folderIconWidth | 24 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
| Avoid excessively long variable names like folderIconHeight | 25 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 27 |
| Avoid unnecessary constructors - the compiler will generate these for you | 30 |
| It is a good practice to call super() in a constructor | 30 |
| Avoid unused formal parameters such as 'column' | 61 |
| Avoid unused formal parameters such as 'hasFocus' | 61 |
| Avoid unused formal parameters such as 'isSelected' | 61 |
| Avoid unused formal parameters such as 'row' | 61 |
| Avoid unused formal parameters such as 'table' | 61 |
| Parameter 'column' is not assigned and could be declared final | 61 |
| Parameter 'hasFocus' is not assigned and could be declared final | 61 |
| Parameter 'isSelected' is not assigned and could be declared final | 61 |
| Parameter 'row' is not assigned and could be declared final | 61 |
| Parameter 'table' is not assigned and could be declared final | 61 |
| Parameter 'value' is not assigned and could be declared final | 61 |
| Parameter 'graphics' is not assigned and could be declared final | 79 |
| Local variable could be declared final | 81 |
| Local variable could be declared final | 82 |
| Local variable could be declared final | 84 |
| Local variable could be declared final | 86 |
| Local variable could be declared final | 87 |
| Local variable could be declared final | 95 |
| Avoid unused formal parameters such as 'newValue' | 107 |
| Avoid unused formal parameters such as 'oldValue' | 107 |
| Avoid unused formal parameters such as 'propertyName' | 107 |
| Parameter 'newValue' is not assigned and could be declared final | 107 |
| Parameter 'oldValue' is not assigned and could be declared final | 107 |
| Parameter 'propertyName' is not assigned and could be declared final | 107 |
| Avoid unused formal parameters such as 'height' | 109 |
| Avoid unused formal parameters such as 'tm' | 109 |
| Avoid unused formal parameters such as 'width' | 109 |
| Avoid unused formal parameters such as 'x' | 109 |
| Avoid unused formal parameters such as 'y' | 109 |
| Avoid variables with short names like tm | 109 |
| Avoid variables with short names like x | 109 |
| Avoid variables with short names like y | 109 |
| Parameter 'height' is not assigned and could be declared final | 109 |
| Parameter 'tm' is not assigned and could be declared final | 109 |
| Parameter 'width' is not assigned and could be declared final | 109 |
| Parameter 'x' is not assigned and could be declared final | 109 |
| Parameter 'y' is not assigned and could be declared final | 109 |
| Avoid unused formal parameters such as 'r' | 111 |
| Avoid variables with short names like r | 111 |
| Parameter 'r' is not assigned and could be declared final | 111 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like triedToLoadImage | 11 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 11 |
| Avoid excessively long variable names like loadImageErrorMessage | 12 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 12 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 14 |
| It is somewhat confusing to have a field name with the same name as a method | 14 |
| Avoid excessively long variable names like isTooltipCached | 16 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Avoid excessively long variable names like cachedTooltip | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 22 |
| Avoid excessively long variable names like imageHasFocus | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Avoid excessively long variable names like imageIsSelected | 24 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 27 |
| Avoid excessively long variable names like componentWidth | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| Avoid excessively long variable names like componentHeight | 30 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 30 |
| Avoid unused formal parameters such as 'column' | 69 |
| Avoid unused formal parameters such as 'hasFocus' | 69 |
| Avoid unused formal parameters such as 'isSelected' | 69 |
| Avoid unused formal parameters such as 'row' | 69 |
| Avoid unused formal parameters such as 'table' | 69 |
| Local variable could be declared final | 157 |
| Local variable could be declared final | 195 |
| Local variable could be declared final | 202 |
| Avoid unused formal parameters such as 'newValue' | 236 |
| Avoid unused formal parameters such as 'oldValue' | 236 |
| Avoid unused formal parameters such as 'propertyName' | 236 |
| Avoid unused formal parameters such as 'height' | 238 |
| Avoid unused formal parameters such as 'tm' | 238 |
| Avoid unused formal parameters such as 'width' | 238 |
| Avoid unused formal parameters such as 'x' | 238 |
| Avoid unused formal parameters such as 'y' | 238 |
| Avoid variables with short names like tm | 238 |
| Avoid variables with short names like x | 238 |
| Avoid variables with short names like y | 238 |
| Avoid unused formal parameters such as 'r' | 240 |
| Avoid variables with short names like r | 240 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 9 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 42 |
| Avoid unused formal parameters such as 'arg0' | 52 |
| Avoid excessively long variable names like componentWidth | 55 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like backBufferImage | 20 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 22 |
| Avoid excessively long variable names like imageRotation | 26 |
| Avoid excessively long variable names like imagePosition | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| Avoid excessively long variable names like messageIfNoAvailableImage | 32 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 32 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 34 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 36 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 38 |
| Avoid excessively long variable names like redoBufferedFont | 40 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 40 |
| Avoid excessively long variable names like componentHeight | 72 |
| Avoid excessively long variable names like componentWidth | 72 |
| Avoid excessively long variable names like affineTransform | 74 |
| Avoid excessively long variable names like outputImageWidth | 79 |
| Avoid excessively long variable names like outputImageHeight | 80 |
| Avoid excessively long variable names like scaleTransform | 87 |
| Avoid excessively long variable names like rotateTransform | 89 |
| Avoid excessively long variable names like translateTransform | 118 |
| Avoid instantiating new objects inside loops | 190 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 39 |
| Avoid excessively long variable names like imageCellRenderer | 47 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 47 |
| Avoid excessively long variable names like folderCellRenderer | 48 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| Avoid excessively long variable names like emptyCellRenderer | 49 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 49 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 52 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 53 |
| Avoid excessively long variable names like lastControlImage | 57 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 57 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 59 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 60 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 62 |
| Avoid excessively long variable names like activeColumntCount | 64 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 64 |
| Avoid calls to overridable methods during construction | 85 |
| Assigning an Object to null is a code smell. Consider refactoring. | 170 |
| Local variable could be declared final | 179 |
| Local variable could be declared final | 215 |
| Local variable could be declared final | 216 |
| Local variable could be declared final | 217 |
| Local variable could be declared final | 222 |
| Local variable could be declared final | 244 |
| Local variable could be declared final | 300 |
| Avoid excessively long variable names like includeOldSelection | 342 |
| Local variable could be declared final | 344 |
| Local variable could be declared final | 345 |
| Local variable could be declared final | 357 |
| Local variable could be declared final | 369 |
| Local variable could be declared final | 408 |
| Local variable could be declared final | 410 |
| Local variable could be declared final | 423 |
| Local variable could be declared final | 425 |
| Avoid unused formal parameters such as 'folder' | 477 |
| Avoid empty 'if' statements | 480 |
| Avoid excessively long variable names like relativePoint | 494 |
| Each class should declare at least one constructor | 598 |
| Avoid variables with short names like e | 616 |
| Avoid variables with short names like e | 625 |
| Each class should declare at least one constructor | 637 |
| Avoid unused formal parameters such as 'column' | 640 |
| Avoid unused formal parameters such as 'hasFocus' | 640 |
| Avoid unused formal parameters such as 'isSelected' | 640 |
| Avoid unused formal parameters such as 'row' | 640 |
| Avoid unused formal parameters such as 'table' | 640 |
| Avoid unused formal parameters such as 'value' | 640 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 25 |
| Avoid excessively long variable names like allItemsCount | 26 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 26 |
| Avoid excessively long variable names like filteredItems | 28 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 28 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 28 |
| Avoid excessively long variable names like filteredItemsCount | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 31 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 31 |
| Avoid excessively long variable names like filteredItemsComparator | 32 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 32 |
| Avoid excessively long variable names like useFoldersFirstWhenSorting | 33 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 33 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 36 |
| It is a good practice to call super() in a constructor | 42 |
| Parameter 'col' is not assigned and could be declared final | 83 |
| Parameter 'row' is not assigned and could be declared final | 83 |
| Local variable could be declared final | 88 |
| Parameter 'cell' is not assigned and could be declared final | 103 |
| Parameter 'cols' is not assigned and could be declared final | 112 |
| Parameter 'filter' is not assigned and could be declared final | 127 |
| Avoid excessively long variable names like selectedImages | 129 |
| Local variable could be declared final | 129 |
| Use ArrayList instead of Vector | 129 |
| Local variable could be declared final | 130 |
| Local variable could be declared final | 133 |
| Local variable could be declared final | 136 |
| Avoid excessively long variable names like selectedImages | 152 |
| Local variable could be declared final | 152 |
| Use ArrayList instead of Vector | 152 |
| Local variable could be declared final | 153 |
| Local variable could be declared final | 156 |
| Parameter 'cell' is not assigned and could be declared final | 204 |
| Avoid excessively long variable names like passedFilters | 206 |
| Local variable could be declared final | 207 |
| Local variable could be declared final | 210 |
| Avoid excessively long variable names like nrOfImagesBefore | 224 |
| Parameter 'nrOfImagesBefore' is not assigned and could be declared final | 224 |
| Parameter 'startRow' is not assigned and could be declared final | 224 |
| Local variable could be declared final | 227 |
| Parameter 'imageModel' is not assigned and could be declared final | 246 |
| Avoid excessively long variable names like nrOfImagesBefore | 248 |
| Local variable could be declared final | 248 |
| Local variable could be declared final | 249 |
| Local variable could be declared final | 251 |
| Parameter 'filesList' is not assigned and could be declared final | 267 |
| Avoid excessively long variable names like nrOfImagesBefore | 269 |
| Local variable could be declared final | 269 |
| Local variable could be declared final | 270 |
| Local variable could be declared final | 271 |
| Avoid instantiating new objects inside loops | 275 |
| Local variable could be declared final | 275 |
| Parameter 'cell' is not assigned and could be declared final | 346 |
| Parameter 'cell' is not assigned and could be declared final | 402 |
| Local variable could be declared final | 404 |
| Local variable could be declared final | 407 |
| Local variable could be declared final | 408 |
| Parameter 'col' is not assigned and could be declared final | 432 |
| Parameter 'row' is not assigned and could be declared final | 432 |
| Parameter 'cell' is not assigned and could be declared final | 442 |
| Local variable could be declared final | 445 |
| Parameter 'index' is not assigned and could be declared final | 458 |
| Avoid unused formal parameters such as 'columnIndex' | 471 |
| Avoid unused formal parameters such as 'rowIndex' | 471 |
| Parameter 'columnIndex' is not assigned and could be declared final | 471 |
| Parameter 'rowIndex' is not assigned and could be declared final | 471 |
| Parameter 'cell' is not assigned and could be declared final | 481 |
| Local variable could be declared final | 483 |
| Avoid if (x != y) ..; else ..; | 487 |
| Parameter 'cell' is not assigned and could be declared final | 504 |
| Local variable could be declared final | 508 |
| Parameter 'filter' is not assigned and could be declared final | 547 |
| Parameter 'filter' is not assigned and could be declared final | 557 |
| Local variable could be declared final | 581 |
| Local variable could be declared final | 584 |
| Parameter 'cellIndex' is not assigned and could be declared final | 601 |
| Local variable could be declared final | 603 |
| Local variable could be declared final | 604 |
| Avoid variables with short names like c | 615 |
| Parameter 'comparator' is not assigned and could be declared final | 634 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 16 |
| Avoid excessively long variable names like loadingImagesMax | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 18 |
| Avoid excessively long variable names like loadingImagesLookupTable | 19 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Avoid excessively long variable names like imageLoadingListener | 20 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Avoid excessively long variable names like cachedImagesMax | 22 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 22 |
| Avoid excessively long variable names like cachedImagesCount | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
| It is a good practice to call super() in a constructor | 40 |
| Parameter 'imageCell' is not assigned and could be declared final | 62 |
| Parameter 'imageCell' is not assigned and could be declared final | 80 |
| Local variable could be declared final | 82 |
| Local variable could be declared final | 83 |
| Avoid if (x != y) ..; else ..; | 85 |
| Parameter 'imageCell' is not assigned and could be declared final | 108 |
| Parameter 'imageCell' is not assigned and could be declared final | 118 |
| Parameter 'imageCell' is not assigned and could be declared final | 151 |
| Parameter 'image' is not assigned and could be declared final | 157 |
| Parameter 'imageCell' is not assigned and could be declared final | 157 |
| Parameter 'image' is not assigned and could be declared final | 168 |
| Parameter 'imageModel' is not assigned and could be declared final | 168 |
| Local variable could be declared final | 170 |
| Parameter 'imageModel' is not assigned and could be declared final | 180 |
| Parameter 'msg' is not assigned and could be declared final | 180 |
| Local variable could be declared final | 182 |
| Avoid excessively long variable names like initialCapacity | 204 |
| Avoid unused formal parameters such as 'eldest' | 210 |
| Parameter 'eldest' is not assigned and could be declared final | 210 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 15 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like additionEvent | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 19 |
| Avoid using implementation types like 'Vector'; use the interface instead | 21 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Use ArrayList instead of Vector | 21 |
| Avoid excessively long variable names like numberOfAvailablePlaces | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Avoid using implementation types like 'Vector'; use the interface instead | 24 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
| Avoid excessively long variable names like numberOfPlaces | 35 |
| Avoid using 'if...else' statements without curly braces | 40 |
| Use ArrayList instead of Vector | 40 |
| Avoid using 'if...else' statements without curly braces | 42 |
| Use ArrayList instead of Vector | 42 |
| Parameter 'timeout' is not assigned and could be declared final | 59 |
| Avoid using if statements without curly braces | 61 |
| A method should have only one exit point, and that should be the last statement in the method | 62 |
| A method should have only one exit point, and that should be the last statement in the method | 69 |
| Parameter 'timeout' is not assigned and could be declared final | 92 |
| Avoid using if statements without curly braces | 94 |
| A method should have only one exit point, and that should be the last statement in the method | 95 |
| Avoid using if statements without curly braces | 97 |
| A method should have only one exit point, and that should be the last statement in the method | 98 |
| A method should have only one exit point, and that should be the last statement in the method | 105 |
| Parameter 'timeout' is not assigned and could be declared final | 129 |
| Avoid using if statements without curly braces | 131 |
| A method should have only one exit point, and that should be the last statement in the method | 132 |
| Local variable could be declared final | 134 |
| A method should have only one exit point, and that should be the last statement in the method | 143 |
| Local variable could be declared final | 147 |
| Avoid using if statements without curly braces | 150 |
| A method should have only one exit point, and that should be the last statement in the method | 151 |
| Avoid using if statements without curly braces | 154 |
| A method should have only one exit point, and that should be the last statement in the method | 155 |
| Avoid using if statements without curly braces | 158 |
| A method should have only one exit point, and that should be the last statement in the method | 159 |
| Call Thread.notifyAll() rather than Thread.notify() | 172 |
| Call Thread.notifyAll() rather than Thread.notify() | 183 |
| Parameter 'item' is not assigned and could be declared final | 192 |
| Parameter 'item' is not assigned and could be declared final | 202 |
| Parameter 'item' is not assigned and could be declared final | 212 |
| Parameter 'index' is not assigned and could be declared final | 217 |
| Parameter 'item' is not assigned and could be declared final | 217 |
| Avoid using if statements without curly braces | 219 |
| A method should have only one exit point, and that should be the last statement in the method | 220 |
| A method should have only one exit point, and that should be the last statement in the method | 224 |
| Local variable could be declared final | 240 |
| Parameter 'index' is not assigned and could be declared final | 254 |
| Local variable could be declared final | 258 |
| A method should have only one exit point, and that should be the last statement in the method | 261 |
| Parameter 'item' is not assigned and could be declared final | 274 |
| Local variable could be declared final | 278 |
| Avoid if (x != y) ..; else ..; | 280 |
| A method should have only one exit point, and that should be the last statement in the method | 282 |
| A method should have only one exit point, and that should be the last statement in the method | 286 |
| A method should have only one exit point, and that should be the last statement in the method | 320 |
| Avoid using 'if...else' statements without curly braces | 320 |
| Avoid using 'if...else' statements without curly braces | 322 |
| A method should have only one exit point, and that should be the last statement in the method | 332 |
| Avoid using 'if...else' statements without curly braces | 332 |
| Avoid using 'if...else' statements without curly braces | 334 |
| Parameter 'listener' is not assigned and could be declared final | 357 |
| Parameter 'listener' is not assigned and could be declared final | 366 |
| Parameter 'item' is not assigned and could be declared final | 375 |
| Local variable could be declared final | 377 |
| Parameter 'item' is not assigned and could be declared final | 388 |
| Local variable could be declared final | 390 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 13 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 13 |
| Avoid modifiers which are implied by the context | 20 |
| Avoid modifiers which are implied by the context | 27 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 26 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| Avoid excessively long variable names like viewerLookupTable | 31 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 31 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 31 |
| Avoid excessively long variable names like imagePropertiesLookupTable | 32 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 32 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 32 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 33 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 33 |
| Avoid excessively long variable names like keepOnWaiting | 35 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 35 |
| Parameter 'queueItem' is not assigned and could be declared final | 65 |
| System.out.println is used | 68 |
| Local variable could be declared final | 70 |
| System.out.println is used | 82 |
| A catch statement should never catch throwable since it includes errors | 84 |
| System.out.println is used | 88 |
| Local variable could be declared final | 106 |
| Assigning an Object to null is a code smell. Consider refactoring. | 112 |
| Parameter 'imageProps' is not assigned and could be declared final | 153 |
| Parameter 'viewer' is not assigned and could be declared final | 153 |
| Local variable could be declared final | 155 |
| Parameter 'imageProps' is not assigned and could be declared final | 166 |
| Parameter 'viewer' is not assigned and could be declared final | 166 |
| Local variable could be declared final | 168 |
| Parameter 'viewer' is not assigned and could be declared final | 194 |
| Local variable could be declared final | 198 |
| Parameter 'imageProps' is not assigned and could be declared final | 211 |
| Local variable could be declared final | 215 |
| Parameter 'imageProps' is not assigned and could be declared final | 229 |
| Parameter 'viewer' is not assigned and could be declared final | 248 |
| Local variable could be declared final | 250 |
| Parameter 'imageProps' is not assigned and could be declared final | 262 |
| Local variable could be declared final | 264 |
| Parameter 'item' is not assigned and could be declared final | 276 |
| Avoid excessively long variable names like imageProperties | 289 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 289 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 289 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 290 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 290 |
| It is a good practice to call super() in a constructor | 297 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 18 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 11 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 15 |
| Avoid excessively long variable names like onlySelectedImages | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 17 |
| Avoid excessively long variable names like filterOnlySelected | 23 |
| It is a good practice to call super() in a constructor | 23 |
| Parameter 'cell' is not assigned and could be declared final | 29 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.File' | 6 |
| Classes implementing Serializable should set a serialVersionUID | 18 |
| Each class should declare at least one constructor | 18 |
| This abstract class does not have any abstract methods | 18 |
| Parameter 'obj' is not assigned and could be declared final | 25 |
| Parameter 'obj' is not assigned and could be declared final | 63 |
| Parameter 'obj' is not assigned and could be declared final | 73 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 11 |
| Avoid unused formal parameters such as 'o1' | 14 |
| Avoid unused formal parameters such as 'o2' | 14 |
| Avoid variables with short names like o1 | 14 |
| Avoid variables with short names like o2 | 14 |
| Parameter 'o1' is not assigned and could be declared final | 14 |
| Parameter 'o2' is not assigned and could be declared final | 14 |
| Local variable could be declared final | 16 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like sortAscending | 13 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 13 |
| It is a good practice to call super() in a constructor | 27 |
| Avoid variables with short names like o1 | 33 |
| Avoid variables with short names like o2 | 33 |
| Parameter 'o1' is not assigned and could be declared final | 33 |
| Parameter 'o2' is not assigned and could be declared final | 33 |
| Local variable could be declared final | 35 |
| Local variable could be declared final | 36 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 40 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 40 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 44 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 44 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like PARENT_DIR_STR | 19 |
| Avoid excessively long variable names like sameCellTypeSorter | 20 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 20 |
| It is a good practice to call super() in a constructor | 26 |
| Avoid variables with short names like o1 | 32 |
| Avoid variables with short names like o2 | 32 |
| Parameter 'o1' is not assigned and could be declared final | 32 |
| Parameter 'o2' is not assigned and could be declared final | 32 |
| Avoid variables with short names like o1 | 73 |
| Avoid variables with short names like o2 | 73 |
| Parameter 'o1' is not assigned and could be declared final | 73 |
| Parameter 'o2' is not assigned and could be declared final | 73 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 18 |
| Parameter 'column' is not assigned and could be declared final | 28 |
| Parameter 'row' is not assigned and could be declared final | 28 |
| Parameter 'table' is not assigned and could be declared final | 28 |
| Local variable could be declared final | 34 |
| Local variable could be declared final | 38 |
| Avoid variables with short names like pt | 41 |
| Local variable could be declared final | 41 |
| Parameter 'cell' is not assigned and could be declared final | 59 |
| Parameter 'table' is not assigned and could be declared final | 59 |
| Parameter 'column' is not assigned and could be declared final | 71 |
| Parameter 'row' is not assigned and could be declared final | 71 |
| Parameter 'table' is not assigned and could be declared final | 71 |
| Local variable could be declared final | 77 |
| Local variable could be declared final | 81 |
| Local variable could be declared final | 84 |
| Parameter 'cell' is not assigned and could be declared final | 117 |
| Parameter 'table' is not assigned and could be declared final | 117 |
| Avoid variables with short names like x | 130 |
| Avoid variables with short names like y | 130 |
| Parameter 'table' is not assigned and could be declared final | 130 |
| Parameter 'x' is not assigned and could be declared final | 130 |
| Parameter 'y' is not assigned and could be declared final | 130 |
| Local variable could be declared final | 132 |
| Local variable could be declared final | 133 |
| Local variable could be declared final | 145 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 154 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 155 |
| Avoid variables with short names like c | 156 |
| Avoid variables with short names like r | 156 |
| It is a good practice to call super() in a constructor | 156 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.swing.DefaultListModel' | 9 |
| Avoid unused imports such as 'javax.swing.JLabel' | 10 |
| Avoid unused imports such as 'javax.swing.ListModel' | 12 |
| Avoid unused imports such as 'javax.swing.event.ListDataListener' | 13 |
| Avoid unused local variables such as 'gamemod' | 23 |
| It is a good practice to call super() in a constructor | 23 |
| Each class should declare at least one constructor | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 31 |
| Parameter 'arg0' is not assigned and could be declared final | 38 |
| Local variable could be declared final | 40 |
| Local variable could be declared final | 42 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 12 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 14 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 16 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.swing.JTextArea' | 11 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 21 |
| Avoid excessively long variable names like modSummaryScrollPane | 22 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 22 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Avoid excessively long variable names like modDescriptionTextArea | 25 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Local variable could be declared final | 76 |
| Local variable could be declared final | 82 |
| Local variable could be declared final | 84 |
| Deeply nested if..then statements are hard to read | 88 |
| Deeply nested if..then statements are hard to read | 94 |
| Local variable could be declared final | 106 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 28 |
| Avoid excessively long variable names like modConfiguration | 30 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 30 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 31 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 32 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 33 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 34 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 35 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 36 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 37 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 37 |
| Avoid excessively long variable names like screenshotsList | 79 |
| Local variable could be declared final | 79 |
| Local variable could be declared final | 80 |
| Avoid excessively long variable names like screenshotsNodeList | 82 |
| Local variable could be declared final | 90 |
| Local variable could be declared final | 91 |
| The String literal "source" appears 4 times in this file; the first occurrence is on line 91 | 91 |
| Avoid excessively long variable names like descriptionStr | 92 |
| Local variable could be declared final | 92 |
| Local variable could be declared final | 93 |
| Avoid instantiating new objects inside loops | 94 |
| An empty statement (semicolon) not part of a loop | 97 |
| Local variable could be declared final | 106 |
| Local variable could be declared final | 107 |
| Avoid excessively long variable names like gameFilesNodeList | 109 |
| Local variable could be declared final | 117 |
| Local variable could be declared final | 118 |
| Local variable could be declared final | 119 |
| Avoid instantiating new objects inside loops | 120 |
| An empty statement (semicolon) not part of a loop | 123 |
| Local variable could be declared final | 132 |
| Local variable could be declared final | 133 |
| Avoid excessively long variable names like authorsNodeList | 135 |
| Local variable could be declared final | 143 |
| Local variable could be declared final | 144 |
| Local variable could be declared final | 145 |
| Local variable could be declared final | 146 |
| Avoid excessively long variable names like authorWebsite | 147 |
| Local variable could be declared final | 147 |
| Avoid instantiating new objects inside loops | 149 |
| Avoid empty catch blocks | 152 |
| An empty statement (semicolon) not part of a loop | 154 |
| Local variable could be declared final | 168 |
| Local variable could be declared final | 173 |
| Local variable could be declared final | 181 |
| Local variable could be declared final | 186 |
| Parameter 'urlStr' is not assigned and could be declared final | 205 |
| Parameter 'isRequired' is not assigned and could be declared final | 229 |
| Parameter 'rootElement' is not assigned and could be declared final | 229 |
| Parameter 'valueName' is not assigned and could be declared final | 229 |
| Parameter 'element' is not assigned and could be declared final | 247 |
| Local variable could be declared final | 250 |
| Parameter 'element' is not assigned and could be declared final | 266 |
| Parameter 'isEntry' is not assigned and could be declared final | 266 |
| Parameter 'nodeName' is not assigned and could be declared final | 266 |
| Parameter 'tagName' is not assigned and could be declared final | 266 |
| Local variable could be declared final | 274 |
| Local variable could be declared final | 282 |
| Local variable could be declared final | 301 |
| Avoid excessively long variable names like screenshotsElement | 306 |
| Local variable could be declared final | 306 |
| Avoid excessively long variable names like gamefilesElement | 313 |
| Local variable could be declared final | 313 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 13 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 15 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 15 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 16 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 18 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 15 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 17 |
| Avoid excessively long variable names like entryNameInPackage | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 19 |
| Avoid excessively long variable names like entryNameInPackage | 26 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.awt.image.BufferedImage' | 6 |
| Avoid unused imports such as 'javax.imageio.ImageIO' | 10 |
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.util.ImageFactory' | 13 |
| Classes implementing Serializable should set a serialVersionUID | 21 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 23 |
| Avoid excessively long variable names like entryNameInPackage | 24 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 24 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 25 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 26 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 26 |
| Parameter 'filepath' is not assigned and could be declared final | 57 |
| Local variable could be declared final | 60 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 20 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 12 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 12 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 12 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 15 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 13 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 19 |
| It is a good practice to call super() in a constructor | 21 |
| Parameter 'entryName' is not assigned and could be declared final | 34 |
| Local variable could be declared final | 36 |
| Parameter 'entryName' is not assigned and could be declared final | 40 |
| Parameter 'entryName' is not assigned and could be declared final | 50 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 19 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 21 |
| Parameter 'entryName' is not assigned and could be declared final | 40 |
| Local variable could be declared final | 42 |
| Parameter 'entryName' is not assigned and could be declared final | 50 |
| Parameter 'entryName' is not assigned and could be declared final | 59 |
| Violation | Line |
|---|---|
| Each class should declare at least one constructor | 17 |
| Violation | Line |
|---|---|
| Avoid excessively long variable names like factoryInstance | 14 |
| It is a good practice to call super() in a constructor | 16 |
| Avoid unused formal parameters such as 'imageStream' | 29 |
| Parameter 'imageStream' is not assigned and could be declared final | 29 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 15 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.swing.JLabel' | 4 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'javax.swing.JLabel' | 5 |
| Avoid unused imports such as 'java.awt.GridBagConstraints' | 6 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Avoid unused private fields such as 'aboutPanel' | 18 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 18 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.io.File' | 4 |
| Avoid unused imports such as 'javax.swing.JSplitPane' | 10 |
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.mod.DefaultGameMod' | 14 |
| Avoid unused imports such as 'net.sourceforge.jsh3modtool.modpackage.FolderModPackage' | 16 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 28 |
| Avoid excessively long variable names like descriptionTextArea | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 29 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 31 |
| Avoid excessively long variable names like screenshotsPanel | 33 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 33 |
| Avoid calls to overridable methods during construction | 41 |
| Parameter 'gamemod' is not assigned and could be declared final | 137 |
| Violation | Line |
|---|---|
| Classes implementing Serializable should set a serialVersionUID | 16 |
| Parameter 'gamemod' is not assigned and could be declared final | 28 |
| Local variable could be declared final | 46 |
| Local variable could be declared final | 47 |
| Avoid instantiating new objects inside loops | 48 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 55 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'gameMod' | 16 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Private field could be made final. It is only initialized in the declaration or constructor. | 16 |
| Avoid excessively long variable names like modSummaryScrollPane | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 20 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 22 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 24 |
| Violation | Line |
|---|---|
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 19 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 21 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 23 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 25 |
| Avoid unused formal parameters such as 'args' | 110 |
| Parameter 'args' is not assigned and could be declared final | 110 |
| Local variable could be declared final | 112 |
| Avoid variables with short names like e | 115 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'java.awt.CardLayout' | 4 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 16 |
| Avoid excessively long variable names like installedModPanel | 17 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 17 |
| Avoid excessively long variable names like availableModsPanel | 18 |
| Found non-transient, non-static member. Please mark as transient or provide accessors. | 18 |